refactor: Moves WorkerPool creation to apply()#26
Merged
Conversation
developit
approved these changes
Jun 6, 2022
developit
left a comment
developit
left a comment
Owner
There was a problem hiding this comment.
Whoops, didn't see this before publishing 1.2.0
Owner
|
Released in 1.3.0 |
Contributor
Author
|
Cheers, thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue came from testing out in
preact-cli.While CLI's setup is pretty niche, this issue can arise if
opimize-pluginis initialized but then removed from the Webpack config (like if a user strips it out using theirpreact.config.js). This seems to lock up the Webpack build, never allowing it to complete. Moving pool creation toapply()when Webpack actually installs the plugin seems to correct the issue.