C#: Remove redundant code from DeadStoreOfLocal.ql#22049
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR simplifies the C# cs/useless-assignment-to-local query by removing a predicate and helper definitions that are redundant given the query already treats all captured locals as potentially live.
Changes:
- Deleted the
mayEscapelogic and related helper predicates/functions fromDeadStoreOfLocal.ql. - Simplified
RelevantDefinition.isMaybeLive()by dropping the redundantmayEscape(v)branch.
Show a summary per file
| File | Description |
|---|---|
| csharp/ql/src/Dead Code/DeadStoreOfLocal.ql | Removes redundant captured-variable escape logic and simplifies liveness reasoning for reported dead stores. |
Copilot's findings
- Files reviewed: 1/1 changed files
- Comments generated: 0
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The removed code was redundant since we filter away results for all captured variables.