fix: remove deprecated --ignore-prepublish from npm install#3709
Closed
ravvdevv wants to merge 1 commit into
Closed
fix: remove deprecated --ignore-prepublish from npm install#3709ravvdevv wants to merge 1 commit into
ravvdevv wants to merge 1 commit into
Conversation
The --ignore-prepublish option has been deprecated in npm 8 and now produces a warning: 'Unknown cli config "--ignore-prepublish". This will stop working in the next major version of npm.' Remove it from the node language installer to prevent CI failures in environments that treat npm warnings as errors. Fixes pre-commit#3517
Member
|
ai slop is not acceptable |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Removes the deprecated
--ignore-prepublishoption from the npm install command in the node language installer.Problem
The
--ignore-prepublishoption was deprecated in npm 8 and now produces a warning:This causes CI failures in environments that treat npm warnings as errors (e.g., GitLab CI).
Changes
pre_commit/languages/node.py: Removed--ignore-prepublishfromlocal_install_cmdTesting
--include=dev,--include=prod,--no-progress,--no-save) are unaffectedFixes #3517