gh-152433: Windows: use GetFileSizeEx instead of GetFileSize#152383
gh-152433: Windows: use GetFileSizeEx instead of GetFileSize#152383thexai wants to merge 1 commit into
Conversation
|
Most changes to Python require a NEWS entry. Add one using the blurb_it web app or the blurb command-line tool. If this change has little impact on Python users, wait for a maintainer to apply the |
|
All commit authors signed the Contributor License Agreement. |
This change is transparent: users won't notice anything different. |
thexai
changed the title
chris-eibl
left a comment
chris-eibl
left a comment
There was a problem hiding this comment.
Thanks, LGTM. Even less code and works the same as before on all supported Windows platforms.
I'm on the fence regarding a news entry - leaving it up to @zooba
GetFileSizeEx is available in all supported Windows versions and has the advantage is also present in UWP, then allows build also in UWP with the same common code. It also simplifies error checking and makes handling files larger than 4GB easier.
thexai
force-pushed
the
windows-getfilesizeex
branch
from
fb47fb6 to
8b9c4cb
Compare
2 participants
GetFileSizeEx is available in all supported Windows versions and has the advantage is also present in UWP, then allows build also in UWP with the same common code.
It also simplifies error checking and makes handling files larger than 4GB easier.
The ultimate goal is to upstream some of Kodi patches required to build Python for Xbox... This is just the first step.