gh-152431: update StreamReader transport after StreamWriter.start_tls#152432
Open
kn1g78 wants to merge 1 commit into
Open
gh-152431: update StreamReader transport after StreamWriter.start_tls#152432kn1g78 wants to merge 1 commit into
kn1g78 wants to merge 1 commit into
Conversation
Keep StreamReader in sync with the upgraded transport after StreamWriter.start_tls(), and add a regression test for the transport replacement.
|
Most changes to Python require a NEWS entry. Add one using the blurb_it web app or the blurb command-line tool. If this change has little impact on Python users, wait for a maintainer to apply the |
|
All commit authors signed the Contributor License Agreement. |
Author
|
I think we can skip the news here :) |
kn1g78
requested review from
1st1,
asvetlov,
kumaraditya303 and
willingc
as code owners
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
After
StreamWriter.start_tls()upgrades a stream transport to TLS, theStreamWriterandStreamReaderProtocolare updated to use the new transport,but the linked
StreamReaderstill keeps the old transport.This change keeps the
StreamReadertransport in sync with the upgradedtransport.
Changes
StreamReaderProtocol._replace_transport()to also replace the linkedStreamReadertransportStreamWriter.start_tls()Issue
Testing
test_streamwriter_start_tls_updates_reader_transport