gh-152445: fix zipfile.writestr() ignoring strict_timestamps when SOURCE_DATE_EPOCH is set#152452
Open
Lohitha0-0 wants to merge 3 commits into
Open
Conversation
…en SOURCE_DATE_EPOCH is set
|
Most changes to Python require a NEWS entry. Add one using the blurb_it web app or the blurb command-line tool. If this change has little impact on Python users, wait for a maintainer to apply the |
|
All commit authors signed the Contributor License Agreement. |
Lohitha0-0
force-pushed
the
gh-152445-zipfile-strict-timestamps-source-date-epoch
branch
from
434f28b to
974fa2b
Compare
…urce-date-epoch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #152445.
ZipInfo._for_archive()(introduced in gh-91279) setsdate_timefromSOURCE_DATE_EPOCHor the system clock, but did not apply thestrict_timestamps=Falseclamping thatZipInfo.from_file()performs.This caused
writestr()to raisestruct.errorwhenstrict_timestamps=FalseandSOURCE_DATE_EPOCH(or the system clock)was set to a date before 1980, instead of silently clamping to 1980-01-01.
The fix mirrors the existing clamp logic in
from_file().